Skip to content

Allow to search for implicits in macros #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

Allow to search for implicits in macros #6819

merged 1 commit into from
Jul 9, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jul 8, 2019
@nicolasstucki nicolasstucki requested a review from liufengyun July 8, 2019 12:10
@nicolasstucki nicolasstucki marked this pull request as ready for review July 8, 2019 13:18
@nicolasstucki nicolasstucki mentioned this pull request Jul 8, 2019
Closed
16 tasks
liufengyun
liufengyun approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@nicolasstucki nicolasstucki force-pushed the quote-implicit-search branch from 98a2573 to 041647c Compare July 9, 2019 07:15
liufengyun
liufengyun approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liufengyun
liufengyun reviewed Jul 9, 2019
View reviewed changes
@liufengyun liufengyun merged commit 863872b into scala:master Jul 9, 2019
@liufengyun liufengyun deleted the quote-implicit-search branch July 9, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun